Add missing deprecations for YAML metadata mapping #9206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
improvement/yaml-deprecation
branch
from
cf73778 to
ca67518
Compare
greg0ire
reviewed
Nov 28, 2021
derrabus
force-pushed
the
improvement/yaml-deprecation
branch
from
ca67518 to
b8d07c3
Compare
greg0ire
approved these changes
Nov 29, 2021
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 29, 2021
* 2.11.x: Add missing deprecations for YAML metadata mapping (doctrine#9206) Drop support for DBAL 3.1 Psalm 4.13.1, PHPStan 1.2.0 (doctrine#9204) Add a psalm type for field mapping Use `equal to` instead of `equal of` in `assertSqlGeneration()` (doctrine#9195) Adding Attributes code block (doctrine#9161)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Nov 29, 2021
* 2.11.x: Add missing deprecations for YAML metadata mapping (doctrine#9206) Drop support for DBAL 3.1 Psalm 4.13.1, PHPStan 1.2.0 (doctrine#9204) Add a psalm type for field mapping Use `equal to` instead of `equal of` in `assertSqlGeneration()` (doctrine#9195) Adding Attributes code block (doctrine#9161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #8465
I've deprecated:
SimplifiedYamlDriversetup::createYAMLMetadataConfiguration()The class and the method don't make much sense if we remove YAML metadata mapping.