Refactor ORMException into an interface #9085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Oct 5, 2021
|
|
||
| /** | ||
| * Should become an interface in 3.0 | ||
| */ | ||
| class ORMException extends BaseORMException | ||
| interface ORMException extends Throwable |
There was a problem hiding this comment.
Extending Throwable can have ugly side-effects on PHP 7.3 and below. I'd suggest that we bump to 7.4 at least, so we don't have to deal with them.
There was a problem hiding this comment.
Fully agree, let's do that.
derrabus
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #8692