Deprecate AbstractHydrator::hydrateRow()
#9072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
force-pushed
the
deprecate/hydrate-row
branch
2 times, most recently
from
c95f870 to
f26002a
Compare
|
Converting to draft for obvious reasons 😛 |
Signed-off-by: Alexander M. Turek <[email protected]>
derrabus
force-pushed
the
deprecate/hydrate-row
branch
from
f26002a to
efebcb9
Compare
greg0ire
approved these changes
Oct 3, 2021
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 3, 2021
* 2.11.x: Deprecate AbstractHydrator::hydrateRow() (doctrine#9072) Reflect latest minor release in metadata Revert "Pin laminas/automatic-releases to 1.11.1" Revert "Try using docker image directly" Revert "Explicitly disallow workflows for tags" Revert "Use org admin token"
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Oct 3, 2021
* 2.11.x: Deprecate AbstractHydrator::hydrateRow() (doctrine#9072) Reflect latest minor release in metadata Revert "Pin laminas/automatic-releases to 1.11.1" Revert "Try using docker image directly" Revert "Explicitly disallow workflows for tags" Revert "Use org admin token" Signed-off-by: Alexander M. Turek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While removing the
iterate()methods, I noticed that the public methodAbstractHydrator::hydrateRow()has become obsolete because we don't call it anymore. I'd like to remove it as well.