Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate testTwoIterateHydrations #9048

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

derrabus
Copy link
Member

If we removed the deprecated iterate() method in 3.0, we would lose coverage here. Because of that, I've duplicated the test using the toIterable() method.

Signed-off-by: Alexander M. Turek <[email protected]>
@derrabus derrabus added this to the 2.9.6 milestone Sep 30, 2021
@derrabus derrabus merged commit 1d4e12b into doctrine:2.9.x Oct 2, 2021
@derrabus derrabus deleted the improvement/iterable-test branch October 2, 2021 15:45
derrabus added a commit to derrabus/orm that referenced this pull request Oct 2, 2021
* 2.9.x:
  Run PHP 8.1 CI with stable dependencies (doctrine#9058)
  Duplicate testTwoIterateHydrations (doctrine#9048)
  Add PHP 8.1 to CI (doctrine#9006)
  Fix locking non-existing entity (doctrine#9053)

Signed-off-by: Alexander M. Turek <[email protected]>
derrabus added a commit to derrabus/orm that referenced this pull request Oct 2, 2021
* 2.9.x:
  Run PHP 8.1 CI with stable dependencies (doctrine#9058)
  Duplicate testTwoIterateHydrations (doctrine#9048)
  Add PHP 8.1 to CI (doctrine#9006)
  Fix locking non-existing entity (doctrine#9053)

Signed-off-by: Alexander M. Turek <[email protected]>
derrabus added a commit to derrabus/orm that referenced this pull request Oct 2, 2021
* 2.9.x:
  Run PHP 8.1 CI with stable dependencies (doctrine#9058)
  Duplicate testTwoIterateHydrations (doctrine#9048)
  Add PHP 8.1 to CI (doctrine#9006)
  Fix locking non-existing entity (doctrine#9053)

Signed-off-by: Alexander M. Turek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants