Fix PersistentCollection::get() returning entity not in the collection #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Sep 27, 2021
| ]); | ||
| } catch (Exception $e) { | ||
| // skip errors | ||
| } |
There was a problem hiding this comment.
Please apply a change similar to what I did in #8962 🙏
|
Does this really require a new testcase with new entities? There is already a bunch of tests related to persistent collections and indexBy feature in general, from my pov it would make sense to just put it there. |
|
Can you please rebase your PR onto 2.10.x? The 2.9.x branch has been closed for bugfixes. |
|
@greg0ire would it be possible to merge this bugfix? It would be really helpful. I spent some time with debbuging because of this and fix seems easy. |
|
@Spilky it targets 2.10.x, which is not maintained, so no. Feel free to open a new PR based on it though. If you do, target 2.14.x |
|
Closing in favor of #10439. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8607