Support for PSR-6 result caches #8996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Sep 10, 2021
| @@ -24,6 +24,8 @@ jobs: | |||
| include: | |||
| - php-version: "8.0" | |||
| dbal-version: "2.13" | |||
| - php-version: "8.0" | |||
| dbal-version: "3.2@dev" | |||
There was a problem hiding this comment.
What should happen to this when 3.2.0 is released? Should we change it to whatever the latest 3.1.x is then?
There was a problem hiding this comment.
We heavily depend on DBAL. I think we should always have a CI job that checks against a dev version of DBAL. When 3.2.0 is released, this job will test against 3.3-dev automatically and I think that's fine.
There was a problem hiding this comment.
Is there a syntax we could use to avoid this 2 being hardcoded here? It's a bit misleading. 3@dev maybe?
|
I pushed an extra commit with tests for some of the uncovered paths, let's see if the build still passes. |
greg0ire
force-pushed
the
improvement/psr6-result-cache
branch
from
cd1f621
to
e47dddc
Compare
greg0ire
reviewed
Sep 10, 2021
greg0ire
force-pushed
the
improvement/psr6-result-cache
branch
2 times, most recently
from
9db2e03
to
7291489
Compare
Co-authored-by: Grégoire Paris <[email protected]>
derrabus
force-pushed
the
improvement/psr6-result-cache
branch
from
7291489
to
996fa77
Compare
Done! |
greg0ire
approved these changes
Sep 11, 2021
|
Thanks @derrabus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows doctrine/dbal#4620
DBAL 3.2 will deprecate Doctrine Cache in favor of PSR-6 for result caches. This PR makes sure we call the non-deprecated methods.
I've also added a CI job that runs against a dev snapshot of DBAL, so we can actually test my changes.