Remove calls to fixSchemaElementName()
#8941
Conversation
derrabus
changed the title
fixSchemaElementName()
derrabus
force-pushed
the
remove/fix-schema-element-name
branch
from
354dc68
to
2226d8c
Compare
derrabus
force-pushed
the
remove/fix-schema-element-name
branch
from
2226d8c
to
ad9f67c
Compare
derrabus
force-pushed
the
remove/fix-schema-element-name
branch
from
ad9f67c
to
8f8726b
Compare
derrabus
force-pushed
the
remove/fix-schema-element-name
branch
from
8f8726b
to
e774c0d
Compare
| @@ -672,6 +666,22 @@ private function determineIdGeneratorStrategy(AbstractPlatform $platform): int | |||
| return ClassMetadata::GENERATOR_TYPE_TABLE; | |||
| } | |||
|
|
|||
| private function truncateSequenceName(string $schemaElementName): string | |||
There was a problem hiding this comment.
Codecov has multiple lines marked as uncovered for truncateSequenceName(). Are these lines relevant?
There was a problem hiding this comment.
Apparently, we're not testing sequences on Oracle. 🤔
There was a problem hiding this comment.
We do test part of this method though, so there must be existing test that we might be enable for Oracle. Let's debug_print_backtrace(); to figure this out :)
There was a problem hiding this comment.
Apparently it's PostgreSQL (not suprised), but I couldn't get the name of the current test. Let's use --debug.
There was a problem hiding this comment.
Ok so it's Doctrine\Tests\ORM\Cache\DefaultCollectionHydratorTest::testImplementsCollectionEntryStructure 🤔 It does use a City with a GeneratedValue, but the end goal does not really seem to be testing sequences.
There was a problem hiding this comment.
Apparently, we're not testing sequences anything on Oracle
FTFY 😛
greg0ire
force-pushed
the
remove/fix-schema-element-name
branch
2 times, most recently
from
423322f
to
e774c0d
Compare
Yet another method that has been removed in DBAL 3.