Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to EchoSQLLogger #8940

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Remove calls to EchoSQLLogger #8940

merged 1 commit into from
Aug 23, 2021

Conversation

derrabus
Copy link
Member

EchoSQLLogger is gone in DBAL 3. Do we actually need it?

@derrabus
Remove calls to EchoSQLLogger
869ff3b 
Signed-off-by: Alexander M. Turek <[email protected]>
greg0ire
greg0ire approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just tests I think it's fine to remove them.

@derrabus derrabus added this to the 2.10.0 milestone Aug 23, 2021
@derrabus derrabus merged commit 930c2e0 into doctrine:2.10.x Aug 23, 2021
@derrabus derrabus deleted the remove/echo-sql-logger branch August 23, 2021 14:23
@github-actions github-actions bot mentioned this pull request Oct 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@beberlei beberlei Awaiting requested review from beberlei

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @greg0ire