Update getAssociationTargetClass phpdoc #8907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Aug 11, 2021
| @@ -3409,6 +3409,9 @@ public function getAssociationNames() | |||
| /** | |||
| * {@inheritDoc} | |||
| * | |||
| * @return string | |||
| * @psalm-return class-string | |||
| * | |||
| * @throws InvalidArgumentException | |||
| */ | |||
| public function getAssociationTargetClass($assocName) | |||
There was a problem hiding this comment.
Not sure why Psalm suddenly requires $assocName to be documented 🤔
There was a problem hiding this comment.
psalm has a "All or nothing" strategy. So indeed, since I add the return tag, I have to add the param too... edited.
greg0ire
approved these changes
Aug 11, 2021
|
Thanks @VincentLanglet ! I squashed and used a commit message explaining why you are doing this: b19a13f |
|
Thanks ! Don't know if this is worth enough for a release, in order to avoid consumer with phpstan/psalm to not having too deal with null values (since the persistence repository was released recently) |
|
The last release is quite old, so while by itself it's probably not worth it, I think we might want to release anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the interface can return null, doctrine/persistence#192, the phpdoc here should be precised because it never return null.