Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types for PHP 8.1 #8894

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Aug 7, 2021

This PR adds a ReturnTypeWillChange to iplementations of various core interfaces to indicate that we intend to add a return type declaration one fine day. This way, we avoid a deprecation warning in PHP 8.1.

Signed-off-by: Alexander M. Turek <[email protected]>
@greg0ire greg0ire added the Bug label Aug 8, 2021
@greg0ire greg0ire merged commit 245563e into doctrine:2.9.x Aug 9, 2021
@greg0ire
Copy link
Member

greg0ire commented Aug 9, 2021

Thanks @derrabus !

@derrabus derrabus deleted the bugfix/return-type-will-change branch August 9, 2021 07:30
@greg0ire greg0ire added this to the 2.9.4 milestone Aug 11, 2021
bendavies added a commit to bendavies/ux that referenced this pull request Jun 16, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 16, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 16, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
bendavies added a commit to bendavies/ux that referenced this pull request Jun 19, 2023
resolves php 8.1 deprecations. see doctrine/orm#8894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants