Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed EntityManagerInteface::copy() #8654

Merged
merged 2 commits into from
Apr 24, 2021
Merged

Removed EntityManagerInteface::copy() #8654

merged 2 commits into from
Apr 24, 2021

Conversation

smilesrg
Copy link
Contributor

#8462

Removed EntityManagerInteface::copy() and it's methods

@greg0ire greg0ire closed this Apr 24, 2021
@greg0ire greg0ire reopened this Apr 24, 2021
greg0ire
greg0ire reviewed Apr 24, 2021
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something should be added to UPGRADE.md

@smilesrg
Copy link
Contributor Author

smilesrg commented Apr 24, 2021 •
edited
Loading

This method was never implemented, and probably, is not used, but it worth adding the notice to the UPGRADE.md. I'll take that.

UPD: Done.

@greg0ire greg0ire requested review from beberlei and ostrolucky April 24, 2021 12:19
@greg0ire greg0ire added this to the 3.0.0 milestone Apr 24, 2021
@greg0ire greg0ire merged commit 1445a65 into doctrine:3.0.x Apr 24, 2021
@greg0ire
Copy link
Member

Thanks @smilesrg!

@smilesrg smilesrg deleted the remove_entitymanager_copy branch April 24, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@ostrolucky ostrolucky ostrolucky approved these changes

@beberlei beberlei Awaiting requested review from beberlei

Assignees
No one assigned
Labels
BC Break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smilesrg @greg0ire @ostrolucky