Describe return types more accurately #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an SA regression introduced when using stricter types in SchemaTool. Fixes doctrine#8642
greg0ire
force-pushed
the
more-accurate-return-type
branch
from
9061d68 to
eb860a7
Compare
simPod
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
As a fix this works 👌🏾.
Generics as mentioned here #8642 (comment) can be added in the future IMO.
|
I gave it a try, you can take a look at doctrine/persistence#167 |
SenseException
approved these changes
Apr 19, 2021
|
Once 2.2.0 is released, I will use generics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an SA regression introduced when using stricter types in
SchemaTool.
Fixes #8642