Proposed fix for #8499

[diego-ninja]

Changed lock function to compare timestamps instead of DateTimeInterface objects directly.

When using optimistic lock with DateTimeInterface based version field a bug appears due to the use of the === operator for comparing the lock version and the entity version. This comparison always resolves to false because the === operator when comparing objects is only true when both sides are the exact same instance of the object.

To fix the issue I have decided to compare timestamps instead the DateTimeInterface based objects directly, calling getTimestamp() method and doing a strict comparison.

Modified OptimisticLockException to use DateTimeInterface instead of DateTime class.

Added test suite to cover case.

Fixes #8499

[greg0ire]

Please improve your commit message according to the contributing guide.

[diego-ninja]

Please improve your commit message according to the contributing guide.

Done.

[greg0ire]

I meant the commit message, so you can squash your current commits together, and reuse your PR message as a commit message. BTW, when you create a PR with just one commit, Github will reuse its message as a PR message.

[diego-ninja]

I meant the commit message, so you can squash your current commits together, and reuse your PR message as a commit message. BTW, when you create a PR with just one commit, Github will reuse its message as a PR message.

I hope it's ok now.

[greg0ire]

I will do it for you.

[greg0ire]

DDC- is a prefix that was used when we were using JIRA a long time ago, I will replace it with GH. Sorry for breaking this BTW, that was due to a CS-fixing commit of mine 🙇

[greg0ire]

🤔 is this line wrong:

orm/lib/Doctrine/ORM/EntityManagerInterface.php

Line 218 in e40ac3e

* @param int|null $lockVersion

? It does not mention \DateTimeInterface although the docs do mention using a datetime field as a revision: https://www.doctrine-project.org/projects/doctrine-orm/en/latest/reference/transactions-and-concurrency.html#locking-support

This line might be wrong too:

orm/lib/Doctrine/ORM/UnitOfWork.php

Line 2461 in e40ac3e

* @param int $lockVersion

[greg0ire]

Looks great 👍