Add psalm annotation to ArrayCollection of Parameters #8357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Please fix the coding standard issues. |
|
@greg0ire CS issues fixed |
SenseException
previously approved these changes
Dec 8, 2020
|
I don't think this qualifies as a bugfix… it touches |
snapshotpl
dismissed
SenseException’s stale review
The base branch was changed.
|
@greg0ire updated to 2.9 |
|
@greg0ire Can you review now? |
greg0ire
previously approved these changes
Feb 6, 2021
|
It looks good to me, but there are conflicts you need to fix. |
|
@greg0ire ready! |
greg0ire
force-pushed
the
add-psalm-annotation
branch
from
9ac141e to
17012f1
Compare
greg0ire
approved these changes
Feb 8, 2021
|
Thanks @snapshotpl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this I always miss Parameters types in collection