Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert to "avoid persisting detached entities" #8109

Merged
merged 1 commit into from
Jul 5, 2020

Conversation

Pictor13
Copy link
Contributor

@Pictor13 Pictor13 commented Apr 16, 2020

The alert is hidden into the code

* NOTE: The persist operation always considers entities that are not yet known to
* this EntityManager as NEW. Do not pass detached entities to the persist operation.

while it's useful to be mentioned in the documentation, the same way it is done for the documentation from Doctrine ODM, as caution alert at the end of the section.

greg0ire
greg0ire previously approved these changes Apr 17, 2020
@greg0ire
Copy link
Member

Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble.

How to do that?

  1. git rebase -i origin/2.7, assuming origin is a git remote that points to this repository, and not your fork. If you're not sure what your remotes are, run git remote -vvv, there should be your fork and the holy/reference/base/origin/whatever-you-call-it repository.
  2. A window will show up with many lines, replace pick with fixup on every line but the first one
  3. Close your editor, git should do its magic, and you should end up with one commit
  4. Use git push --force to overwrite what you already push. Don't forget the --force option otherwise git will try to merge both things together.

The alert is hidden into the code of ``EntityManager``,
while it's useful to be mentioned in the documentation.
@greg0ire greg0ire requested a review from SenseException April 17, 2020 19:02
@Pictor13
Copy link
Contributor Author

Pictor13 commented Apr 17, 2020

Thank you for the instructions @greg0ire!
(even though I usually don't like to force push on PRs 😅)

@beberlei beberlei merged commit 75fe18e into doctrine:2.7 Jul 5, 2020
@beberlei beberlei added this to the 2.7.4 milestone Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants