Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation of default generated value behavior #8068

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

jorrit
Copy link
Contributor

@jorrit jorrit commented Mar 12, 2020

When reading about the default behavior of @GeneratedValue I noticed a mismatch in the basic-mapping docs. The introduction tells that PostgreSQL uses SERIAL by default, while later on it says sequence (which is the right one). This small PR fixes this.

Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, with the example above in the docs it should result in a sequence in PostgreSQL. Thank you for your fix.

@SenseException SenseException merged commit cd905ff into doctrine:2.7 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants