Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not used variable $reflFieldValue in ObjectHydrator #7840

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Remove not used variable $reflFieldValue in ObjectHydrator #7840

merged 1 commit into from
Sep 30, 2019
+1 −1

Conversation

peter-gribanov
Copy link
Contributor

fix #7834

@peter-gribanov peter-gribanov mentioned this pull request Sep 30, 2019
Closed
@mikeSimonson mikeSimonson self-assigned this Sep 30, 2019
mikeSimonson
mikeSimonson approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@mikeSimonson mikeSimonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peter-gribanov

@mikeSimonson mikeSimonson merged commit d528f70 into doctrine:master Sep 30, 2019
@peter-gribanov peter-gribanov deleted the reflFieldValue branch September 30, 2019 08:40
@lcobucci lcobucci added this to the 3.0 milestone Oct 1, 2019
@lcobucci
Copy link
Member

lcobucci commented Oct 1, 2019

@peter-gribanov I'm a bit confused here... this has been reported to v2.6 but sent to master. Which branch should have been the destination?

@peter-gribanov
Copy link
Contributor Author

@lcobucci this problem is in versions 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1. In version 2.0 there is no this problem.

@lcobucci
Copy link
Member

lcobucci commented Oct 2, 2019

@peter-gribanov alright, thanks for your reply!
Branches < 2.6 aren't supported so these aren't relevant. I'll backport this one to 2.6, which will also be applied in 2.7 once it gets rebased.

Please check https://github.com/doctrine/orm#which-branch-should-i-choose on the next PRs 👍

@peter-gribanov peter-gribanov restored the reflFieldValue branch October 3, 2019 08:11
@peter-gribanov peter-gribanov deleted the reflFieldValue branch October 3, 2019 08:14
@peter-gribanov peter-gribanov mentioned this pull request Oct 3, 2019
Merged
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeSimonson mikeSimonson mikeSimonson approved these changes

Assignees

@mikeSimonson mikeSimonson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused local variable 'reflFieldValue'
4 participants
@peter-gribanov @lcobucci @mikeSimonson @greg0ire