Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

null values in cached entity fix #7749

Closed
wants to merge 1 commit into from
Closed

null values in cached entity fix #7749

wants to merge 1 commit into from

Conversation

AlexSmerw
Copy link

This is fix for issue 7735

Ocramius
Ocramius suggested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change requires a test case that fails before the patch, and passes after the patch.

@Ocramius
Copy link
Member

@AlexSmerw could you also target 2.6 with this fix, please?

@AlexSmerw
Copy link
Author

@AlexSmerw could you also target 2.6 with this fix, please?

Done #7750

@lcobucci
Copy link
Member

Closing here to keep the fix only for 2.6, we'll port it to master once things are integrated.

@lcobucci lcobucci closed this Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius requested changes

Assignees

@AlexSmerw AlexSmerw

Labels
Bug Missing Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexSmerw @Ocramius @lcobucci