Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change APC to OPcache in improving-performance.rst #7610

Merged
merged 1 commit into from
Sep 20, 2019
Merged

Change APC to OPcache in improving-performance.rst #7610

merged 1 commit into from
Sep 20, 2019

Conversation

smtchahal
Copy link
Contributor

OPcache is a lot better supported now than APC, which is apparently not maintained anymore.

@Ocramius Ocramius added this to the 2.6.4 milestone Feb 14, 2019
@holtkamp
Copy link
Contributor

OPcache is a lot better supported now than APC

Well, I guess it depends.. OPCache can not be easily purged using a "control panel" interface. APCu can be purged this way

which is apparently not maintained anymore

Last release was 6 days ago? https://github.com/krakjoe/apcu/releases

or am I missing something...

@apfelbox
Copy link

@holtkamp APCu and APC are two different tools.

@holtkamp
Copy link
Contributor

aah, yeah, that is true. In that case I would describe both OPCache and APCu, each has (dis)advantages

@apfelbox
Copy link

APCu certainly has advantages, but it just isn't an opcode cache. So in this case it would be incorrect, because saying "use a bytecode cache like [...] APCu" is wrong – it isn't one. It is for storing user data, not internally generated opcodes.

@holtkamp
Copy link
Contributor

Ahh, ok, is that the intent of this commit. Then nevermind my remarks! Sorry 😄

greg0ire
greg0ire previously approved these changes Feb 16, 2019
@greg0ire
Copy link
Member

I approve the changes, but maybe you could improve the commit message subject? "Update improving-performance.rst" does not really tell us what you did. The commit message body is good though 👍

OPcache is a lot better supported now than APC,
which is apparently not maintained anymore.
@smtchahal smtchahal changed the title Update improving-performance.rst Change APC to OPcache in improving-performance.rst … Feb 16, 2019
@smtchahal smtchahal changed the title Change APC to OPcache in improving-performance.rst … Change APC to OPcache in improving-performance.rst Feb 16, 2019
@smtchahal
Copy link
Contributor Author

@greg0ire Just made another amended commit with a different commit title.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better!

@Majkl578
Copy link
Contributor

OPCache can not be easily purged using a "control panel" interface

@holtcamp This is not true, there are multiple admin interfaces for OPcache as well. Some examples:

In that case I would describe both OPCache and APCu, each has (dis)advantages

Note that APCu is not a bytecode/opcode cache but only a key-value store, so it's not an alternative to OPCache.


Generally speaking this article needs some work to make it reflect current state of PHP ecosystem, e.g. next paragraph also mentions obsolete APC and Memcache.

@lcobucci lcobucci self-assigned this Sep 20, 2019
@lcobucci lcobucci merged commit 3d8b672 into doctrine:2.6 Sep 20, 2019
Voziv added a commit to ratehub/doctrine2 that referenced this pull request Oct 22, 2019
v2.6.4

[![Build Status](https://travis-ci.org/doctrine/orm.svg?branch=v2.6.4)](https://travis-ci.org/doctrine/orm)

In this release we've fixes many bugs (including a performance regression) and
made the v2.x series compatible with PHP 7.4.

--------------------------------------------

- Total issues resolved: **11**
- Total pull requests resolved: **32**
- Total contributors: **30**

Improvement
-----------

 - [7785: Fix "access array offset on value of type null" PHP 7.4 notices](doctrine#7785) thanks to @mlocati
 - [7142: Rename this repository to doctrine/orm](doctrine#7142) thanks to @greg0ire

Bug
------------------

 - [7821: Bug: doctrine#7820 paginator ignores dbal type conversions in identifiers](doctrine#7821) thanks to @Ocramius
 - [7778: Guard L2C regions against corrupted data](doctrine#7778) thanks to @umpirsky
 - [7767: PersistentCollection::matching() does not respect the collections native sorting](doctrine#7767) thanks to @stephanschuler
 - [7766: Respect collection orderBy meta when matching()](doctrine#7766) thanks to @stephanschuler
 - [7761: Do not modify UOW on PersistentCollection::clear() when owner has DEFFERED&doctrine#95;EXPLICIT change tracking policy](doctrine#7761) thanks to @paxal
 - [7750: Fix incorrect return of null values in L2C](doctrine#7750) thanks to @AlexSmerw
 - [7737: Fix MEMBER&doctrine#95;OF comparison when using criteria in query builder](doctrine#7737) thanks to @Smartel1
 - [7735: Null in fields value in Cached Entity several times on day on high-load project.](doctrine#7735) thanks to @AlexSmerw
 - [7630: Fix doctrine#7629 - `scheduledForSynchronization` leaks memory when using `@ORM\ChangeTrackingPolicy("DEFERRED&doctrine#95;EXPLICIT")`](doctrine#7630) thanks to @yethee
 - [7528: Prevent `UnitOfWork` lookup for DBAL types specified in `Doctrine\ORM\Query#setParameter()`](doctrine#7528) thanks to @Ocramius
 - [7322: JoinedSubclassPersister pass identifier types on delete](doctrine#7322) thanks to @dennisenderink and @fred-jan
 - [7266: Call to a member function resolveAssociationEntries() on boolean {"detail":"&doctrine#91;object&doctrine#93; (Symfony\\Component\\Debug\\Exception\\FatalThrowableError(code: 0): Call to a member function resolveAssociationEntries() on boolean at /www/vendor/doctrine/orm/lib/Doctrine/ORM/Cache/DefaultQueryCache.php:140)"}](doctrine#7266) thanks to @mingmingxianseng
 - [4632: DDC-3789: Paginator does not convert entity ids if they are value objects](doctrine#4632) thanks to @doctrinebot

Documentation
-------------

 - [7818: Add note into docs about not using SimpleAnnotationReader](doctrine#7818) thanks to @SenseException
 - [7791: Fix preFlush event documentation stating incorrectly that flush can be called safely](doctrine#7791) thanks to @Steveb-p
 - [7753: Add ORM annotations in getting-started docs](doctrine#7753) thanks to @SenseException and @wajdijurry
 - [7744: Fixed a typo-error](doctrine#7744) thanks to @noobshow
 - [7732: &doctrine#91;Documentation&doctrine#93; Missing comma fix](doctrine#7732) thanks to @lchrusciel
 - [7729: Update DATE&doctrine#95;ADD and DATE&doctrine#95;SUB docs](doctrine#7729) thanks to @JoppeDC
 - [7672: Added cross-links to relevant documentation](doctrine#7672) thanks to @jschaedl
 - [7612: Update ordered-associations.rst](doctrine#7612) thanks to @spirlici
 - [7610: Change APC to OPcache in improving-performance.rst ](doctrine#7610) thanks to @smtchahal
 - [7596: Correct method names and broken link in docs](doctrine#7596) thanks to @mbessolov
 - [7577: Fix of single link to dbal docs in advanced-configuration.rst](doctrine#7577) thanks to @SenseException
 - [7572: Remove codeigniter Framework example](doctrine#7572) thanks to @SenseException
 - [7571: Fix typo in inheritance mappings docs](doctrine#7571) thanks to @batwolf
 - [7557: Change Stackoverflow tag to doctrine-orm](doctrine#7557) thanks to @malarzm
 - [7551: &doctrine#91;2.6&doctrine#93; Migrate repository name doctrine/doctrine2 -> doctrine/orm](doctrine#7551) thanks to @Majkl578
 - [7530: Documentation error typo fix: s/Used-defined/User-Defined](doctrine#7530) thanks to @vladyslavstartsev
 - [7519: doctrine#7518 Fixed type mismatch between `EntityRepository#&doctrine#95;&doctrine#95;construct()` and its documented constructor arguments](doctrine#7519) thanks to @koftikes
 - [7518: `EntityRepository::&doctrine#95;&doctrine#95;construct()` expects `Doctrine\ORM\EntityManager` instead of actual required `EntityManagerInterface`](doctrine#7518) thanks to @koftikes
 - [7490: Fix broken link](doctrine#7490) thanks to @vladyslavstartsev
 - [7483: Fixed a minor syntax issue](doctrine#7483) thanks to @javiereguiluz

CI
-----------------

 - [7794: Fix test compatibility with DBAL 2.10.x-dev](doctrine#7794) thanks to @lcobucci
 - [7731: Replace custom install script with add-on](doctrine#7731) thanks to @greg0ire
 - [7473: Incremental CS checks in 2.x branches](doctrine#7473) thanks to @Majkl578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants