Use non-deprecated version of Lexer and Inflector

[Majkl578]

As of doctrine/common#845, Doctrine\Common\Lexer and Doctrine\Common\Util\Inflector trigger silent deprecations.

[Ocramius]

LGTM 👍

@Majkl578 any composer.json changes required?

[Majkl578]

Not necessarily, we still depend on Common which requires both of the packages. :) Do we want them explicitly listed here?

(Will address master later separately.)

[lcobucci]

Not necessarily, we still depend on Common which requires both of the packages. :) Do we want them explicitly listed here?

@Majkl578 as long we don't plan to modify common and break everything is good HAHAHAH

Let's get it merged!

[stof]

@lcobucci we should indeed add direct requirements on these packages though. but this could be done as part of #7249 instead.

[stof]

@lcobucci this fix also needs to be applied in master btw, not only in 2.6

[Majkl578]

we should indeed add direct requirements on these packages though

We don't need to do this now in 2.6 / 2.x imho since doctrine/common 2.x will always ship them.

this fix also needs to be applied in master btw

As said above:

(Will address master later separately.)

Master will be updated to not depend on doctrine/common, only separate packages. I'll likely cherry-pick this into #7249.
The tricky part is PropertyChangedListener + NotifyPropertyChanged, until it's decided what do do with those, we can't simply drop common yet. Maybe temporarily disabling the feature in master would be sufficient short-term.

[stof]

@Majkl578 addressing it in master is exactly about applying this commit + adding the explicit requirements (once you drop the dependency). I think applying this part already makes sense to avoid the deprecation warnings (especially given that the work on #7249 has not started yet).

[stof]

and even if you don't apply it to master for now, 2.7 needs it though