Deprecate ClassMetadataInfo #6886

greg0ire · 2017-12-13T19:32:33Z

The deprecation happened 7 years ago: #249

Here is how I proceeded:

I moved all the code back from ClassMetadataInfo to ClassMetadata
I aliased ClassMetadataInfo to ClassMetadata.
I kept a ClassMetadataInfo class definition in an if (\false) statement to provide IDE autocompletion.

This class is deprecated. See doctrine/orm#6886

Majkl578 · 2017-12-16T04:20:27Z

tests/Doctrine/Tests/ORM/Mapping/ClassMetadataInfoTest.php

+     */
+    public function testTheClassIsDeprecated()
+    {
+        class_exists(ClassMetadataInfo::class);


Should at least has assertTrue(). Maybe instantiating ReflectionClass would be better as it would throw i.e. once CMI BC is dropped.

Once CMI BC is dropped, the class will no longer exist, and this will throw too. Even without the assertTrue, right? I mean there is the @expectedDeprecation, and it will no longer be satisfied, I don't know why you want me to add assertTrue. I'll add it but I don't understand what the point is.

Doesn't matter really, just thought it may be easier to see failed assertion first than no deprecation thrown or whatever that message looks like.

Majkl578 · 2017-12-16T04:20:55Z

tests/Doctrine/Tests/ORM/Mapping/ClassMetadataInfoTest.php

+     * @group legacy
+     * @expectedDeprecation Doctrine\ORM\Mapping\ClassMetadataInfo is deprecated since 2.x and will be removed in 3.0. Use Doctrine\ORM\Mapping\ClassMetadata instead.
+     */
+    public function testTheClassIsDeprecated()


return types here and below please

Majkl578 · 2017-12-16T04:22:40Z

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

-use Doctrine\Common\ClassLoader;
-use Doctrine\ORM\Cache\CacheException;
+@trigger_error(sprintf(
+    '%s is deprecated since 2.x and will be removed in 3.0. Use %s instead.',


Note: Revisit message later, it may be ComponentMetadata instead of ClassMetadata.

Majkl578 · 2017-12-16T04:23:30Z

lib/Doctrine/ORM/Mapping/ClassMetadataInfo.php

-     * @todo 3.0 Remove this. PersisterHelper should fix it somehow
-     */
-    public function getTypeOfField($fieldName)
-


Why do we need this? Should also use ::class.

We don't: it says "remove this"

This comment was for:

class_exists('Doctrine\ORM\Mapping\ClassMetadata');

GitHub somehow put it on wrong line, maybe too large diff...

Majkl578 · 2017-12-16T17:47:02Z

Also please add note to UPGRADE document, thanks.

greg0ire · 2017-12-17T11:05:45Z

Triggering the build again

greg0ire · 2017-12-20T14:20:43Z

Rebased

lcobucci · 2017-12-20T22:47:57Z

@greg0ire the destination branch should be 2.7

greg0ire · 2018-01-17T22:32:39Z

Moved the controversial autoloading to another PR, so that this is easy to merge.

The clearer the better.

greg0ire · 2018-01-25T19:48:50Z

Don't merge, this crashes:

<?php

require 'vendor/autoload.php';

use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Mapping\ClassMetadataInfo;

class A
{
    public function __construct(ClassMetadataInfo $a)
    {
    }
}

new A(new ClassMetadata('whatever'));

Changing the order of the 2 tests is important because the first one autoloads CMI

greg0ire · 2018-02-05T16:52:31Z

Forgot to say that it is now "fixed", but the fix is a bit ugly

lcobucci · 2019-11-15T13:51:40Z

@greg0ire moving this to 2.8.0 as we have conflicts to address and want to release 2.7.0 ASAP.

greg0ire changed the title ~~Deprecate classmetadatainfo~~ Deprecate ClassMetadataInfo Dec 13, 2017

greg0ire force-pushed the deprecate_classmetadatainfo branch 4 times, most recently from 64d7c45 to 7c60cfc Compare December 13, 2017 20:21

greg0ire added a commit to greg0ire/SonataDoctrineORMAdminBundle that referenced this pull request Dec 13, 2017

Replace references to ClassMetadataInfo

55e5bba

This class is deprecated. See doctrine/orm#6886

greg0ire mentioned this pull request Dec 13, 2017

Replace references to ClassMetadataInfo sonata-project/SonataDoctrineORMAdminBundle#782

Merged

greg0ire added a commit to greg0ire/SonataDoctrineORMAdminBundle that referenced this pull request Dec 13, 2017

Replace references to ClassMetadataInfo

6837af8

This class is deprecated. See doctrine/orm#6886

greg0ire added a commit to greg0ire/SonataDoctrineORMAdminBundle that referenced this pull request Dec 13, 2017

Replace references to ClassMetadataInfo

e908f5f

This class is deprecated. See doctrine/orm#6886

greg0ire added a commit to greg0ire/SonataDoctrineORMAdminBundle that referenced this pull request Dec 13, 2017

Replace references to ClassMetadataInfo

e2f8e40

This class is deprecated. See doctrine/orm#6886

greg0ire added a commit to greg0ire/SonataDoctrineORMAdminBundle that referenced this pull request Dec 14, 2017

Replace references to ClassMetadataInfo

b63517d

This class is deprecated. See doctrine/orm#6886

greg0ire added a commit to greg0ire/SonataDoctrineORMAdminBundle that referenced this pull request Dec 14, 2017

Replace references to ClassMetadataInfo

5b91edb

This class is deprecated. See doctrine/orm#6886

jordisala1991 pushed a commit to sonata-project/SonataDoctrineORMAdminBundle that referenced this pull request Dec 14, 2017

Replace references to ClassMetadataInfo

b1ba615

This class is deprecated. See doctrine/orm#6886

Majkl578 added the Deprecation label Dec 16, 2017

Majkl578 added this to the 2.7.0 milestone Dec 16, 2017

Majkl578 reviewed Dec 16, 2017

View reviewed changes

greg0ire force-pushed the deprecate_classmetadatainfo branch 3 times, most recently from e9d8093 to 983000d Compare December 16, 2017 14:06

greg0ire closed this Dec 17, 2017

greg0ire reopened this Dec 17, 2017

greg0ire force-pushed the deprecate_classmetadatainfo branch 2 times, most recently from 19c55f7 to 6ba3fe2 Compare December 17, 2017 11:27

greg0ire mentioned this pull request Dec 17, 2017

Use stable packages #6887

Merged

Bump version to 2.7-dev

afae3f7

greg0ire force-pushed the deprecate_classmetadatainfo branch from 4f831e9 to d0e70ce Compare December 20, 2017 14:20

Include package name in deprecation messages

ee7caef

The clearer the better.

greg0ire force-pushed the deprecate_classmetadatainfo branch from 6621e57 to ee7caef Compare January 18, 2018 17:21

Ensure old type hints still work

07f7476

Changing the order of the 2 tests is important because the first one autoloads CMI

greg0ire mentioned this pull request Feb 5, 2018

Moved stuff from CoreBundle sonata-project/sonata-doctrine-extensions#82

Merged

Majkl578 force-pushed the 2.7 branch from aeef8fa to 1951401 Compare August 8, 2018 18:03

greg0ire mentioned this pull request Aug 13, 2018

Validate XML mapping against XSD file #6728

Merged

3 tasks

Majkl578 force-pushed the 2.7 branch from 4e71572 to 01cff97 Compare September 23, 2018 05:14

Majkl578 force-pushed the 2.7 branch from 01cff97 to 62fb493 Compare November 11, 2018 22:32

lcobucci force-pushed the 2.7 branch from 62fb493 to c036c0b Compare November 21, 2018 00:41

alcaeus mentioned this pull request Jan 9, 2019

Add deprecation layers doctrine/mongodb-odm#1924

Merged

lcobucci force-pushed the 2.7 branch from 9e73672 to 40f2406 Compare September 23, 2019 09:29

lcobucci force-pushed the 2.7 branch from 40f2406 to d9c30e3 Compare October 23, 2019 13:59

lcobucci modified the milestones: 2.7.0, 2.8.0 Nov 15, 2019

beberlei modified the milestones: 2.8.0, 2.8.1, 2.8.2 Dec 4, 2020

beberlei removed this from the 2.8.2 milestone Dec 13, 2020

greg0ire force-pushed the 2.7 branch 3 times, most recently from e531738 to 66c95a6 Compare December 1, 2021 20:54

greg0ire changed the base branch from 2.7 to 2.10.x December 28, 2021 22:50

greg0ire mentioned this pull request Apr 27, 2022

Reference ClassMetadaInfo less #9691

Merged

greg0ire closed this Mar 22, 2023

greg0ire deleted the deprecate_classmetadatainfo branch March 22, 2023 18:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate ClassMetadataInfo #6886

Deprecate ClassMetadataInfo #6886

greg0ire commented Dec 13, 2017 •

edited

Loading

Majkl578 Dec 16, 2017

greg0ire Dec 16, 2017

Majkl578 Dec 16, 2017

Majkl578 Dec 16, 2017

Majkl578 Dec 16, 2017

Majkl578 Dec 16, 2017

greg0ire Dec 16, 2017

Majkl578 Dec 16, 2017

Majkl578 commented Dec 16, 2017

greg0ire commented Dec 17, 2017

greg0ire commented Dec 20, 2017

lcobucci commented Dec 20, 2017

greg0ire commented Jan 17, 2018

greg0ire commented Jan 25, 2018 •

edited

Loading

greg0ire commented Feb 5, 2018

lcobucci commented Nov 15, 2019

Deprecate ClassMetadataInfo #6886

Deprecate ClassMetadataInfo #6886

Conversation

greg0ire commented Dec 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 commented Dec 16, 2017

greg0ire commented Dec 17, 2017

greg0ire commented Dec 20, 2017

lcobucci commented Dec 20, 2017

greg0ire commented Jan 17, 2018

greg0ire commented Jan 25, 2018 • edited Loading

greg0ire commented Feb 5, 2018

lcobucci commented Nov 15, 2019

greg0ire commented Dec 13, 2017 •

edited

Loading

greg0ire commented Jan 25, 2018 •

edited

Loading