Added deprecation warnings for 2.x #6869

Majkl578 · 2017-12-08T20:47:47Z

Based on UPGRADE document for 3.0.

Deprecations added for:

EntityManager::copy() method
EntityManager::merge() method
EntityManager::detach() method
EntityManager::flush() calls with arguments
YAML mapping driver
Version class
Proxy interface
Configuration::getProxy*()
ProxyFactory
proxy Autoloader

I have not added any notes about mapping/metadata changes here because it's still pretty unstable.

Tests marked as @legacy use any of the deprecated methods.
Added explicit deprecation tests for deprecated methods.

~~I'd like to get these into 2.6, there is no reason to delay it.~~

Majkl578 · 2017-12-08T20:48:38Z

composer.json

@@ -31,7 +31,8 @@
        "doctrine/coding-standard": "^1.0",
        "phpunit/phpunit": "^6.0",
        "squizlabs/php_codesniffer": "^3.1",
-        "symfony/yaml": "~3.4|~4.0"
+        "symfony/phpunit-bridge": "^3.3|^4.0",
+        "symfony/yaml": "4.0.1"


This is just temporary hack to work around symfony/symfony#25405 on CI.

greg0ire · 2017-12-09T11:48:16Z

lib/Doctrine/ORM/EntityManager.php

@@ -353,6 +353,13 @@ public function createQueryBuilder()
     */
    public function flush($entity = null)
    {
+        if (func_num_args() === 1) {


Consider using > 0

Isn't $entity !== null simpler? I mean, only the first argument is used anyway

Yeah even better

That would still allow flush(null) though. I'll change it to !== 0.

greg0ire · 2017-12-09T11:48:51Z

lib/Doctrine/ORM/EntityManager.php

     */
    public function detach($entity)
    {
+        @trigger_error('Method ' . __METHOD__ . '() is deprecated and will be removed in Doctrine 3.0, please migrate to ' . self::class . '::clear().', E_USER_DEPRECATED);


Linebreak here

Also, EntityManager#clear() has a different behaviour... and I'm not even sure if we should point people to do partial cleaning of the UoW, it might have the very same issues we have with EntityManager#detach().

greg0ire · 2017-12-09T11:49:25Z

lib/Doctrine/ORM/Mapping/Driver/YamlDriver.php

@@ -44,6 +44,8 @@ class YamlDriver extends FileDriver
     */
    public function __construct($locator, $fileExtension = self::DEFAULT_FILE_EXTENSION)
    {
+        @trigger_error('YAML mapping driver is deprecated and will be removed in Doctrine 3.0, please migrate to annotation or XML driver.', E_USER_DEPRECATED);


lcobucci

LGTM, just some minor comments.

We just need to keep in mind that our plan is to release 2.6 WITHOUT the deprecation notices. 2.7 would be the one adding them.

lcobucci · 2017-12-10T13:29:56Z

lib/Doctrine/ORM/EntityManager.php

@@ -353,6 +353,13 @@ public function createQueryBuilder()
     */
    public function flush($entity = null)
    {
+        if (func_num_args() === 1) {


Isn't $entity !== null simpler? I mean, only the first argument is used anyway

lcobucci · 2017-12-10T13:32:07Z

lib/Doctrine/ORM/Proxy/Proxy.php

@@ -26,6 +26,8 @@
 *
 * @author Roman Borschel <[email protected]>
 * @since 2.0
+ *
+ * @deprecated This class is deprecated and will be removed in Doctrine 3.0, proxies will no longer implement it.


Does it make sense to mention which interface should be used? So that people can already start preparing their stuff

Not sure about this one, we would be referencing 3rd party code (ProxyManager) which is not required in Composer.

lcobucci · 2017-12-10T13:40:24Z

lib/Doctrine/ORM/EntityManager.php

     */
    public function detach($entity)
    {
+        @trigger_error('Method ' . __METHOD__ . '() is deprecated and will be removed in Doctrine 3.0, please migrate to ' . self::class . '::clear().', E_USER_DEPRECATED);


Also, EntityManager#clear() has a different behaviour... and I'm not even sure if we should point people to do partial cleaning of the UoW, it might have the very same issues we have with EntityManager#detach().

Majkl578 · 2017-12-11T16:19:23Z

We just need to keep in mind that our plan is to release 2.6 WITHOUT the deprecation notices.

Well, the sooner we ship them, the better for users, but if there are other reasons, 2.7 is fine by me.

Majkl578 · 2017-12-11T22:29:39Z

Updated, added deprecations for codegen (#6870).

Majkl578 · 2017-12-17T04:23:04Z

I've also added deprecatons for:

Configuration::getProxy*()
ProxyFactory
proxy Autoloader

Also partially imported UPGRADE notes from develop and reworded them (no mapping-related changes since it's unfinished).

greg0ire · 2017-12-17T10:50:42Z

UPGRADE.md

@@ -1,3 +1,103 @@
+# Upgrade to 2.7
+
+## BC Break: Deprecated code generators and related console commands


Deprecations are not BC-breaks, are they?

greg0ire · 2017-12-17T10:51:11Z

lib/Doctrine/ORM/Configuration.php

@@ -70,6 +70,8 @@ public function setProxyDir($dir)
     * Gets the directory where Doctrine generates any necessary proxy class files.
     *
     * @return string|null
+     *
+     * @deprecated


Why not also trigger a deprecation error?

There is no replacement, it would be an error that cannot be muted/fixed, it would be just annoying without benefit.

…ethod Deprecation of EntityManager copy method

Majkl578 · 2018-01-11T19:59:19Z

Rebased.

hkdobrev · 2018-10-10T01:55:23Z

I think deprecations for named queries should be added as well.

https://github.com/doctrine/doctrine2/blob/master/UPGRADE.md#bc-break-removed-support-for-named-queries-and-named-native-queries

Majkl578 added the Deprecation label Dec 8, 2017

Majkl578 commented Dec 8, 2017

View reviewed changes

Majkl578 force-pushed the deprecations-2.x branch from 9ab6c3c to 68e7d06 Compare December 8, 2017 20:49

Majkl578 requested a review from Ocramius December 8, 2017 20:52

greg0ire reviewed Dec 9, 2017

View reviewed changes

lcobucci added this to the 2.7.0 milestone Dec 10, 2017

lcobucci suggested changes Dec 10, 2017

View reviewed changes

Majkl578 force-pushed the deprecations-2.x branch from 68e7d06 to ff822e0 Compare December 11, 2017 22:28

Majkl578 mentioned this pull request Dec 12, 2017

[Parameter] Deprecate names starting or ending with a colon #6880

Closed

Majkl578 force-pushed the deprecations-2.x branch 2 times, most recently from 93e5747 to 278edf9 Compare December 17, 2017 04:19

Majkl578 changed the base branch from master to 2.7 December 17, 2017 04:24

greg0ire reviewed Dec 17, 2017

View reviewed changes

Majkl578 force-pushed the deprecations-2.x branch 2 times, most recently from f74c575 to 0be38dd Compare December 18, 2017 00:46

Majkl578 force-pushed the 2.7 branch from e314222 to 6becdfb Compare December 18, 2017 01:22

Bump version to 2.7-dev

afae3f7

lcobucci force-pushed the 2.7 branch from 6becdfb to afae3f7 Compare December 20, 2017 01:02

Majkl578 force-pushed the deprecations-2.x branch from 0be38dd to 5b775da Compare December 20, 2017 23:52

Majkl578 mentioned this pull request Dec 21, 2017

make:doctrine:entities command symfony/maker-bundle#95

Closed

Majkl578 force-pushed the deprecations-2.x branch 2 times, most recently from 4caef22 to 4257a99 Compare January 1, 2018 20:29

SenseException added 2 commits January 2, 2018 21:43

Set copy-method as deprecated

df28f00

Add deprecation of EntityManagerInterface::copy() to upgrade information

296bd28

SenseException and others added 4 commits January 4, 2018 21:19

Create 2.7 upgrade headline for deprecation changes

63c6526

Merge pull request doctrine#6803 from SenseException/deprecate-copy-m…

f4eb8ca

…ethod Deprecation of EntityManager copy method

Added deprecation warnings for 2.x

6f3c438

Upgrading notes for 2.7

d3f80eb

Majkl578 force-pushed the deprecations-2.x branch from 4257a99 to d3f80eb Compare January 11, 2018 19:59

Ocramius mentioned this pull request Jan 18, 2018

DDC-1879: Provide failing test case #6850

Closed

Majkl578 force-pushed the 2.7 branch from aeef8fa to 1951401 Compare August 8, 2018 18:03

Majkl578 force-pushed the 2.7 branch from 4e71572 to 01cff97 Compare September 23, 2018 05:14

Majkl578 force-pushed the 2.7 branch from 01cff97 to 62fb493 Compare November 11, 2018 22:32

lcobucci force-pushed the 2.7 branch from 62fb493 to c036c0b Compare November 21, 2018 00:41

Majkl578 closed this Apr 16, 2019

Majkl578 deleted the deprecations-2.x branch April 16, 2019 19:51

lcobucci mentioned this pull request Nov 15, 2019

Add deprecation warnings for 2.7.x #7901

Merged

Ocramius assigned lcobucci Nov 15, 2019

lcobucci removed this from the 2.7.0 milestone Nov 18, 2019

beberlei mentioned this pull request Feb 6, 2021

Deprecate EntityGenerator and Exporters #8458

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added deprecation warnings for 2.x #6869

Added deprecation warnings for 2.x #6869

Majkl578 commented Dec 8, 2017 •

edited

Loading

Majkl578 Dec 8, 2017

greg0ire Dec 9, 2017 •

edited

Loading

lcobucci Dec 10, 2017

greg0ire Dec 10, 2017

Majkl578 Dec 11, 2017

greg0ire Dec 9, 2017

lcobucci Dec 10, 2017

greg0ire Dec 9, 2017

lcobucci left a comment

lcobucci Dec 10, 2017

lcobucci Dec 10, 2017

Majkl578 Dec 11, 2017

lcobucci Dec 10, 2017

Majkl578 commented Dec 11, 2017

Majkl578 commented Dec 11, 2017 •

edited

Loading

Majkl578 commented Dec 17, 2017

greg0ire Dec 17, 2017

greg0ire Dec 17, 2017

Majkl578 Dec 17, 2017

Majkl578 commented Jan 11, 2018

hkdobrev commented Oct 10, 2018

		@@ -1,3 +1,103 @@
		# Upgrade to 2.7

		## BC Break: Deprecated code generators and related console commands

Added deprecation warnings for 2.x #6869

Added deprecation warnings for 2.x #6869

Conversation

Majkl578 commented Dec 8, 2017 • edited Loading

Choose a reason for hiding this comment

greg0ire Dec 9, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcobucci left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 commented Dec 11, 2017

Majkl578 commented Dec 11, 2017 • edited Loading

Majkl578 commented Dec 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majkl578 commented Jan 11, 2018

hkdobrev commented Oct 10, 2018

Majkl578 commented Dec 8, 2017 •

edited

Loading

greg0ire Dec 9, 2017 •

edited

Loading

Majkl578 commented Dec 11, 2017 •

edited

Loading