#6759 showstopper one-to-one inverse not being loaded with correct identifier restrictions when defining joinColumn
#6760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an identifier from the owning side value Fixes #6759
alcaeus
reviewed
Oct 8, 2017
| @@ -802,13 +804,11 @@ public function loadOneToOneEntity(array $assoc, $sourceEntity, array $identifie | |||
|
|
|||
| // unset the old value and set the new sql aliased value here. By definition | |||
| // unset($identifier[$targetKeyColumn] works here with how UnitOfWork::createEntity() calls this method. | |||
There was a problem hiding this comment.
Comment is out of date - there's no unset left.
lcobucci
suggested changes
Oct 8, 2017
| } | ||
|
|
||
| /** | ||
| * @group #6759 |
There was a problem hiding this comment.
All the other test cases don't have the #, I'd remove it for consistency.
lcobucci
approved these changes
Oct 8, 2017
lcobucci
deleted the
fix/#6759-showstopper-one-to-one-inverse-not-being-loaded-with-correct-identifier-restrictions
branch
maglnet
pushed a commit
to maglnet/doctrine2
that referenced
this pull request
Oct 10, 2018
maglnet
pushed a commit
to maglnet/doctrine2
that referenced
this pull request
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6759