Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5804 #6485 Versioning doesn't work with a custom type primary key #6496

Closed
wants to merge 5 commits into from
Closed

#5804 #6485 Versioning doesn't work with a custom type primary key #6496

wants to merge 5 commits into from

Conversation

astepin
Copy link
Contributor

@astepin astepin commented Jun 9, 2017

This PR is based on #6485. I've just added a test.

@alle alle mentioned this pull request Jun 12, 2017
Merged
@Ocramius Ocramius added the Bug label Jun 20, 2017
@Ocramius Ocramius added this to the 2.6.0 milestone Jun 20, 2017
@Ocramius Ocramius self-assigned this Aug 21, 2017
@Ocramius
Copy link
Member

Argh, this is a bit of a "lots of people dancing around, stepping on each other's toes". @lcobucci has already added the tests in #5804, so this is no longer needed, as @astepin's work is already integrated in master.

Thanks nonetheless! \o/

@Ocramius Ocramius closed this Aug 21, 2017
@Ocramius Ocramius changed the title Fixes #5804 with tests #5804 #6485 Versioning doesn't work with a custom type primary key Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
Bug Duplicate
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@astepin @Ocramius