Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDC-2248: Expire result cache functionality not implemented #2947 #6390

Closed
wants to merge 0 commits into from

Conversation

bruno-ds
Copy link

PR for this issue : #2947 (comment)

I don't know how to run the test... sorry

@theofidry
Copy link

I don't know how to run the test...

@bruno-ds one easy way to figure it out is to look at the .travis.yml. After a quick glance, it doesn't seem it requires much:

  • run phpunit specifying the appropriate config file with the option -c
  • ensure you have the right DB setup for the tests (if you don't want to bother, I think sqlite should be enough for your tests)

@bruno-ds
Copy link
Author

Well, I cannot have a working env. : ./vendor/bin/phpunit --configuration ./tests/mysqlconf.xml ./tests/Doctrine/Tests/ORM/Functional/Ticket/StupidlyNamedTest.php

Doctrine\DBAL\Cache\CacheException: Trying to cache a query but no result driver is configured.

@lcobucci
Copy link
Member

@bruno-ds this is what you're looking for: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/caching.html#result-cache

You can just use the ArrayCache for that purpose.

@bruno-ds
Copy link
Author

please note that I had to change tests/Doctrine/Tests/OrmFunctionalTestCase.php in order to activate
$config->setResultCacheImpl(self::$_resultCacheImpl);

@lcobucci
Copy link
Member

@bruno-ds thanks for you contribution, I've simplified the tests a bit and provided a fix for it on #6417.

@Ocramius
Copy link
Member

Ocramius commented May 3, 2017

Handled in #6417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants