Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony 3.0 components #1310

Merged
merged 1 commit into from
Nov 5, 2015
Merged

Allow symfony 3.0 components #1310

merged 1 commit into from
Nov 5, 2015

Conversation

nicolas-grekas
Copy link
Member

Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0

Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0
@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3584

We use Jira to track the state of pull requests and the versions they got
included in.

@nicolas-grekas
Copy link
Member Author

Please note that symfony can not be properly tested until this one is merged

@nicolas-grekas
Copy link
Member Author

ping @Ocramius
we must tweak our composer.json file in order to test Symfony 3.0 properly right now

@Ocramius
Copy link
Member

Ocramius commented Aug 2, 2015

We can't ensure compat with symfony 3.0 until it gets to RC state (frozen).
We already had enough trouble by allowing symfony 2.7 :(
On Aug 2, 2015 11:54, "Nicolas Grekas" [email protected] wrote:

ping @Ocramius https://github.com/Ocramius
we must tweak our composer.json file in order to test Symfony 3.0 properly
right now


Reply to this email directly or view it on GitHub
#1310 (comment).

@stof
Copy link
Member

stof commented Aug 2, 2015

@Ocramius the Console component should be quite safe. There are no big BC breaks planned in it (the BC break is adding new methods in the OutputInterface, and this does not impact Doctrine as it does not re-implement its own output class)

@nicolas-grekas
Copy link
Member Author

See symfony/symfony#15432

@Ocramius
Copy link
Member

Ocramius commented Aug 3, 2015

@stof I'll let semver decide that once there is a tagged BC-frozen version.
Poke back when at RC stage, right now I don't feel like upgrading and then chasing ghosts :-\

Yes, this is chicken and egg, but users can still have the root composer.json patched for the beta/RC stages.

@nicolas-grekas
Copy link
Member Author

ping @Ocramius we can't seriously tag 3.0 without merging symfony/symfony#15432 but this PR blocks Same for doctrine/DoctrineCacheBundle#48

@Ocramius
Copy link
Member

Ocramius commented Nov 3, 2015

@nicolas-grekas shouldn't there be an RC or beta? Any ref to current stability? That said, can possibly tag tonight, but only the ORM (bundle not up to me)

@stof
Copy link
Member

stof commented Nov 3, 2015

@Ocramius there will be beta. but we need to stop faking versions before tagging a beta release

@Ocramius
Copy link
Member

Ocramius commented Nov 3, 2015

Alright
On Nov 3, 2015 15:09, "Christophe Coevoet" [email protected] wrote:

@Ocramius https://github.com/Ocramius there will be beta. but we need
to stop faking versions before tagging a beta release


Reply to this email directly or view it on GitHub
#1310 (comment).

@stof
Copy link
Member

stof commented Nov 3, 2015

@Ocramius note that I'm not asking you to tag a stable Doctrine version allowing Symfony 3 before the Symfony 3 RC releasese are there. Having a dev or beta version of doctrine during the beta releases of Symfony 3 is OK (and it allows you to polish the compat, even though it should be OK)

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Nov 4, 2015
@Ocramius Ocramius self-assigned this Nov 5, 2015
Ocramius added a commit that referenced this pull request Nov 5, 2015
@Ocramius Ocramius merged commit 06c1943 into doctrine:master Nov 5, 2015
@Ocramius
Copy link
Member

Ocramius commented Nov 5, 2015

@nicolas-grekas now in 2.6.x-dev :-)

@nicolas-grekas
Copy link
Member Author

Thanks ! What's the planned date for 2.6 to be tagged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants