-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow symfony 3.0 components #1310
Conversation
Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3584 We use Jira to track the state of pull requests and the versions they got |
Please note that symfony can not be properly tested until this one is merged |
ping @Ocramius |
We can't ensure compat with symfony 3.0 until it gets to RC state (frozen).
|
@Ocramius the Console component should be quite safe. There are no big BC breaks planned in it (the BC break is adding new methods in the OutputInterface, and this does not impact Doctrine as it does not re-implement its own output class) |
@stof I'll let semver decide that once there is a tagged BC-frozen version. Yes, this is chicken and egg, but users can still have the root composer.json patched for the beta/RC stages. |
ping @Ocramius we can't seriously tag 3.0 without merging symfony/symfony#15432 but this PR blocks Same for doctrine/DoctrineCacheBundle#48 |
@nicolas-grekas shouldn't there be an RC or beta? Any ref to current stability? That said, can possibly tag tonight, but only the ORM (bundle not up to me) |
@Ocramius there will be beta. but we need to stop faking versions before tagging a beta release |
Alright
|
@Ocramius note that I'm not asking you to tag a stable Doctrine version allowing Symfony 3 before the Symfony 3 RC releasese are there. Having a dev or beta version of doctrine during the beta releases of Symfony 3 is OK (and it allows you to polish the compat, even though it should be OK) |
@nicolas-grekas now in |
Thanks ! What's the planned date for 2.6 to be tagged? |
Tests should tell if any deprecated interfaces of Symfony are used. If not, then the bundle is defacto compatible with 3.0