Run risky code in finally block #11646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I move the call to |
SenseException
previously approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Should I move the call to commit() inside the finally block as well? 🤔
I don't know. It looks like it would all be the same in your changes. Logically, from a reading perspective, it would look weird if the commit would be in finally
Does anyone know why $conn->isTransactionActive() wasn't used in the EntityManager in the past?
catch blocks are not supposed to fail. If you want to do something despite an exception happening, you should do it in a finally block. Closes doctrine#7545
greg0ire
force-pushed
the
finally-fix-bug
branch
from
a62c5df
to
51be1b1
Compare
|
I talked a bit more with @alcaeus and it wouldn't be problematic from a reading perspective only: if an exception happens after the actual commit, you don't want to rollback. I'll try adding the guard clause as well as tests. |
It maybe happen that the SQL COMMIT statement is successful, but then something goes wrong. In that kind of case, you do not want to attempt a rollback. This was implemented in UnitOfWork::commit(), but for some reason not in the similar EntityManager methods.
greg0ire
force-pushed
the
finally-fix-bug
branch
from
955a03d
to
b6137c8
Compare
derrabus
approved these changes
Oct 10, 2024
This was referenced Oct 11, 2024
derrabus
pushed a commit
to doctrine/dbal
that referenced
this pull request
Oct 11, 2024
<!-- Fill in the relevant information below to help triage your pull request. --> | Q | A |------------- | ----------- | Type | bug | Fixed issues | #4846 #### Summary Let's do the same thing as for ORM in doctrine/orm#11646 This somehow solves issue we tried to resolve in #4846 by providing original exception in Previous.
xabbuh
added a commit
to symfony/symfony
that referenced
this pull request
Oct 17, 2024
This PR was merged into the 5.4 branch. Discussion ---------- synchronize line numbers in deprecations baseline | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT line numbers changed in doctrine/orm#11646 Commits ------- c31d79a synchronize line numbers in deprecations baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catchblocks are not supposed to fail. If you want to do something despite an exception happening, you should do it in afinallyblock.(finally) Fixes #7545