Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the \Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker() method #11641

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Deprecate the \Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker() method #11641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3c1d71
Deprecate the `\Doctrine\ORM\Query\Parser::setCustomOutputTreeWalker(…
mpdude Oct 9, 2024
25a5fe0
Address GH feedback
mpdude Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Query/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,13 @@
*/
public function setCustomOutputTreeWalker($className)
{
Deprecation::trigger(
'doctrine/orm',
'https://github.com/doctrine/orm/pull/11641',
'%s is deprecated, set the output walker class in a query hint instead',
mpdude marked this conversation as resolved.
Show resolved Hide resolved
__METHOD__

Check warning on line 207 in src/Query/Parser.php

View check run for this annotation

Codecov / codecov/patch

src/Query/Parser.php#L203-L207 

Added lines #L203 - L207 were not covered by tests
);

$this->customOutputWalker = $className;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Tests/ORM/Query/LanguageRecognitionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public function parseDql(string $dql, array $hints = []): ParserResult
$parser = new Query\Parser($query);

// We do NOT test SQL output here. That only unnecessarily slows down the tests!
$parser->setCustomOutputTreeWalker(NullSqlWalker::class);
$query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, NullSqlWalker::class);

return $parser->parse();
}
Expand Down
Loading