Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guides as dev dependency #11614

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Guides as dev dependency #11614

merged 1 commit into from
Sep 29, 2024

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Sep 27, 2024

Needs doctrine/doctrine-website#618

Note that there isn't a version of guides which is compatible with PHP 8.1, and I don't want contributors (or us, in the CI) to have to tweak the composer.json to be able to install the project so I'm targeting 3.2.x.

It is better if contributors can check the docs by themselves.
@greg0ire greg0ire changed the base branch from 2.19.x to 3.2.x September 27, 2024 17:44
@greg0ire greg0ire marked this pull request as ready for review September 27, 2024 19:44
@greg0ire greg0ire added this to the 3.2.3 milestone Sep 29, 2024
@greg0ire greg0ire merged commit 93ce84f into doctrine:3.2.x Sep 29, 2024
65 checks passed
@greg0ire greg0ire deleted the guides-as-dep branch September 29, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants