[2.19.x] Fetching entities with Composite Key Relations and null values #11506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbundyra
force-pushed
the
composite-key-relations-3
branch
3 times, most recently
from
23e197d
to
a22feed
Compare
|
Please squash both commits and use a summary of the description of #11486 . This should be understandable with the git log alone. |
greg0ire
reviewed
Jun 19, 2024
michalbundyra
force-pushed
the
composite-key-relations-3
branch
from
917163d
to
ceeccb2
Compare
|
@greg0ire thanks, squashed, rebased and force-pushed now. |
Can you please amend your commit message to include a summary of the description? |
|
More on this in the contributing guide. |
michalbundyra
force-pushed
the
composite-key-relations-3
branch
from
ceeccb2
to
7201c0e
Compare
Remove redundant condition to check if target class contains foreign identifier in order to allow fetching a null for relations with composite keys, when part of the key value is null.
michalbundyra
force-pushed
the
composite-key-relations-3
branch
from
7201c0e
to
96d13ac
Compare
|
@greg0ire thanks, pushed now, hope it makes sense. |
greg0ire
approved these changes
Jun 19, 2024
SenseException
approved these changes
Jun 20, 2024
|
Thanks @michalbundyra ! |
Yes, it should get merged up at some point. When that happens, maybe we will have to look at your PR to resolve conflicts/adapt the code, or maybe not and then you can rebase and improve things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #11486 into 2.19.x