Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with actual lock modes #11465

Merged
merged 1 commit into from
May 21, 2024
Merged

Test with actual lock modes #11465

merged 1 commit into from
May 21, 2024

Conversation

derrabus
Copy link
Member

EntityPersisterTestCase uses dummy integers as lock modes in all tests. This won't work anymore when lock modes are supposed to be passed as enum cases. Let's use the proper constants instead.

@derrabus derrabus added this to the 2.19.6 milestone May 21, 2024
@derrabus derrabus requested a review from greg0ire May 21, 2024 08:30
@derrabus derrabus mentioned this pull request May 21, 2024
Merged
@derrabus derrabus merged commit 552eae3 into doctrine:2.19.x May 21, 2024
54 checks passed
@derrabus derrabus deleted the improvement/persister-lock-mode branch May 21, 2024 10:30
derrabus added a commit that referenced this pull request May 21, 2024
@derrabus
Merge branch '2.19.x' into 3.1.x
a90ee5c 
* 2.19.x:
  Test with actual lock modes (#11465)
  Backport test for Query::setLockMode() (#11463)
derrabus added a commit that referenced this pull request May 21, 2024
@derrabus
Merge branch '3.1.x' into 3.2.x
22b1f52 
* 3.1.x:
  Fix failed merge (#11464)
  Test with actual lock modes (#11465)
  Backport test for Query::setLockMode() (#11463)
  Fix return type of Query::getLockMode() (#11462)
derrabus added a commit that referenced this pull request May 21, 2024
@derrabus
Merge branch '3.2.x' into 4.0.x
b2a09b9 
* 3.2.x:
  Fix failed merge (#11464)
  Test with actual lock modes (#11465)
  Backport test for Query::setLockMode() (#11463)
  Fix return type of Query::getLockMode() (#11462)
derrabus added a commit that referenced this pull request May 21, 2024
@derrabus
Merge branch '2.19.x' into 2.20.x
bf3e082 
* 2.19.x:
  Psalm 5.24.0 (#11467)
  PHPStan 1.11.1 (#11466)
  Test with actual lock modes (#11465)
  Backport test for Query::setLockMode() (#11463)
@github-actions github-actions bot mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Test Suite
Projects
None yet
Milestone
2.19.6
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @greg0ire