Remove obsolete and unnecessary properties from Table attribute (#11351)
#11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SenseException
previously approved these changes
Mar 13, 2024
|
Having doubts regarding whether this is the right target branch for this/whether there should be a deprecation instead. @derrabus , WDYT? |
|
Indeed, this is a breaking change. We need to deprecate those properties first. Target 3.2.x for the deprecation and 4.0.x for the removal. |
greg0ire
reviewed
Mar 14, 2024
There was a problem hiding this comment.
Retargeted the branch. Please add a note about this in UPGRADE.md and open a separate PR deprecating both properties.
DaDeather
force-pushed
the
11351-remove-obsolete-indexes-and-unique-constraint-properties-from-table-attribute
branch
from
b1b6de7 to
f71c7f7
Compare
greg0ire
approved these changes
Mar 15, 2024
Here's the one for the deprecation: #11357 |
beberlei
previously approved these changes
Mar 16, 2024
SenseException
previously approved these changes
Mar 17, 2024
greg0ire
requested changes
Mar 18, 2024
DaDeather
force-pushed
the
11351-remove-obsolete-indexes-and-unique-constraint-properties-from-table-attribute
branch
from
3dba7fb to
07fd9df
Compare
👍 done! |
…ctrine#11351) The properties `indexes` and `uniqueConstraints` were present before and were used for the `AnnotationDriver` but were never implemented for the `AttributeDriver`. Since the `AnnotationDriver` doesn't exist anymore these can be safely removed reducing possible confusion when defining indices and uniqueConstraints in the `Table` attribute which never worked anyway.
DaDeather
force-pushed
the
11351-remove-obsolete-indexes-and-unique-constraint-properties-from-table-attribute
branch
from
07fd9df to
9430d56
Compare
greg0ire
approved these changes
Mar 18, 2024
|
Congrats on your first contribution @DaDeather ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties
indexesanduniqueConstraintswere present before and were used for theAnnotationDriverbut were never implemented for theAttributeDriver.Since the
AnnotationDriverdoesn't exist anymore these can be safely removed reducing possible confusion when defining indices and uniqueConstraints in theTableattribute which never worked anyway.Fixes #11351