Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version ORM from 2 to 3 in docs #11221

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

andreybolonin
Copy link
Contributor

No description provided.

@@ -1,4 +1,4 @@
Welcome to Doctrine 2 ORM's documentation!
Welcome to Doctrine 3 ORM's documentation!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove that number entirely

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@derrabus
Copy link
Member

derrabus commented Feb 5, 2024

Even if this is just a trivial change, please take a second to write a meaningful PR title. Thank you.

@andreybolonin andreybolonin changed the title Update index.rst Update version ORM from 2 to 3 Feb 6, 2024
@andreybolonin andreybolonin changed the title Update version ORM from 2 to 3 Update version ORM from 2 to 3 in docs Feb 6, 2024
@derrabus derrabus added this to the 3.0.1 milestone Feb 6, 2024
@derrabus derrabus merged commit 1854ce2 into doctrine:3.0.x Feb 6, 2024
1 check passed
derrabus added a commit to derrabus/orm that referenced this pull request Feb 7, 2024
* 3.0.x:
  Revert "Merge pull request doctrine#11229 from greg0ire/add-columns"
  Add columns for 3.1.x and 4.0x
  Update version ORM from 2 to 3 in docs (doctrine#11221)
  Clean up outdated sentence (doctrine#11224)
  Update README.md
  Point link to correct upgrade guide (doctrine#11220)
  Ignore subclasses without discriminatorValue when generating discriminator column condition SQL (doctrine#11200)
  Update branches in README
derrabus added a commit to derrabus/orm that referenced this pull request Feb 7, 2024
* 3.1.x:
  Add TokenType class (doctrine#11228)
  Revert "Merge pull request doctrine#11229 from greg0ire/add-columns"
  Add columns for 3.1.x and 4.0x
  Update version ORM from 2 to 3 in docs (doctrine#11221)
  Clean up outdated sentence (doctrine#11224)
  Update README.md
  Point link to correct upgrade guide (doctrine#11220)
  Ignore subclasses without discriminatorValue when generating discriminator column condition SQL (doctrine#11200)
  Update branches in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants