Use foreach on iterable to prevent table locks during tests #11167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobvandevijver
force-pushed
the
fix-eager-iterable-loading-test
branch
from
8fe6f1b to
4875f4c
Compare
greg0ire
approved these changes
Jan 18, 2024
|
Thanks @bobvandevijver ! |
greg0ire
added a commit
to greg0ire/doctrine-orm
that referenced
this pull request
Jan 20, 2024
…ble-loading-test Use foreach on iterable to prevent table locks during tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix table lock issues when merging into 3.x (see #11166). The iterator was not marked as finished, as this particular test case does not clear it records between the test, which meant that the test I added actually has 5 owners in the iterator.
By cleaning on setup and using a foreach which will yield only a single record, the iterator is closed and the table lock is released.
I am open for improvements to ensure the table contents is cleared between runs, but for now this works.