-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON mapping linting against subset of builtin types #11076
Conversation
33d1977
to
0d2bd95
Compare
93d2057
0d2bd95
to
93d2057
Compare
How does this fix play with union types? For example: #[Column(type: 'json')]
private array|bool|null $data; |
It is not linted, because it's already ignored here: orm/lib/Doctrine/ORM/Tools/SchemaValidator.php Lines 373 to 376 in 93d2057
|
Ah, perfect. 😎 |
tests/Doctrine/Tests/ORM/Functional/Ticket/GH11072/GH11072EntityBasic.php
Outdated
Show resolved
Hide resolved
93d2057
to
8bdc88e
Compare
Actually, I think we should extend this condition to also include |
8bdc88e
to
bb54409
Compare
Updated to always ignore mixed type |
Can we get this merged? 🙂 |
Thank you |
Spotted while trying to merge doctrine#11076 (among other things) up into 3.0.x. On that branch, it is no longer possible for an entity to extend another entity without specifying an inheritance mapping type. I think the goal of that inheritance was just to reuse the identifier anyway, so let's just duplicate the identifier declaration instead.
Closes #11072