Enforce native type declarations #11013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
native-type-decl
branch
2 times, most recently
from
ae8af1a to
b13462e
Compare
greg0ire
changed the title
derrabus
reviewed
Oct 21, 2023
greg0ire
force-pushed
the
native-type-decl
branch
from
b13462e to
46c04f4
Compare
This requires heavily adapting tests, because the proxy instance must: - be an instance of InternalProxy (easy) - be a valid entity (hard, especially for PHPUnit)
I tried to avoid changes in tests, so as to not unnecessarily widen the gap between 2.x and 3.x.
greg0ire
force-pushed
the
native-type-decl
branch
from
46c04f4 to
8ab0af3
Compare
greg0ire
commented
Oct 22, 2023
|
|
||
| return parent::getProxy($className, $identifier); | ||
| } | ||
| }; |
There was a problem hiding this comment.
@derrabus I pushed a new commit, it reworks this test and the one below, allowing to use a native return type declaration for ProxyFactory::getProxy()
SenseException
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to avoid changes in
tests, so as to not unnecessarily widen thegap between 2.x and 3.x.