Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proxy name resolver #11009

Merged

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Oct 14, 2023

It is important to have the same implementation as used in doctrine/persistence without relying on copy/paste.

Simplified alternative to #11008

It is important to have the same implementation as used in
doctrine/persistence without relying on copy/paste.
@greg0ire greg0ire force-pushed the decouple-from-class-utils-simplified branch from 02a5f3d to 8a621e9 Compare October 14, 2023 14:55
Copy link
Member

@beberlei beberlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This keeps the surface of this code low and hidden from sight.

@derrabus derrabus added this to the 2.17.0 milestone Oct 14, 2023
@derrabus derrabus merged commit bf69d0a into doctrine:2.17.x Oct 14, 2023
58 checks passed
@greg0ire greg0ire deleted the decouple-from-class-utils-simplified branch October 14, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants