Remove partial syntax in DQL #10985
Merged
Remove partial syntax in DQL #10985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forbidding building partial objects will be attempted in a separate PR, it will require a substantial rework of the tests, they seem to heavily rely on that ability. A possible solution might be to build a factory, allowing us to specify just the properties that we care about. Note that building such objects through that API does not trigger any deprecation. |
greg0ire
force-pushed
the
remove-partial-from-dql
branch
from
0c42805
to
9e1946f
Compare
|
Converting to draft as I've found more stuff to remove |
greg0ire
force-pushed
the
remove-partial-from-dql
branch
2 times, most recently
from
3a78c29
to
7c1adbf
Compare
beberlei
previously approved these changes
Oct 11, 2023
UPGRADE.md
Outdated
| @@ -1,5 +1,13 @@ | |||
| # Upgrade to 3.0 | |||
|
|
|||
| ## BC BREAK: Partial objects are removed | |||
|
|
|||
| - The `PARTIAL` keyword no longer exists. | |||
There was a problem hiding this comment.
Suggested change
| - The `PARTIAL` keyword no longer exists. | |
| - The `PARTIAL` keyword in DQL no longer exists. |
greg0ire
force-pushed
the
remove-partial-from-dql
branch
from
7c1adbf
to
318aa82
Compare
It is no longer possible to use the "PARTIAL" keyword in a DQL query, or to artificially build an AST with a partial object expression. It is still possible to use the result set mapping API to build partial objects.
greg0ire
force-pushed
the
remove-partial-from-dql
branch
from
318aa82
to
689da1f
Compare
beberlei
approved these changes
Oct 11, 2023
|
I wonder what was the reasoning behind this move. I use this feature time to time and I know ApiPlatform rely on it. |
|
The place to discuss that is #8471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer possible to use the
PARTIALkeyword in a DQL query, or to artificially build an AST with a partial object expression. It is still possible to use the result set mapping API to build partial objects.