Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assert that BIGINTs are stored as strings #10980

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Don't assert that BIGINTs are stored as strings #10980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/Doctrine/Tests/ORM/Functional/Ticket/DDC3634Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,24 +60,24 @@ public function testSavesVeryLargeIntegerAutoGeneratedValue(): void
self::assertSame($veryLargeId, $entity->id);
}

public function testSavesIntegerAutoGeneratedValueAsString(): void
public function testSavesIntegerAutoGeneratedValue(): void
{
$entity = new DDC3634Entity();

$this->_em->persist($entity);
$this->_em->flush();

self::assertIsString($entity->id);
self::assertNotNull($entity->id);
}

public function testSavesIntegerAutoGeneratedValueAsStringWithJoinedInheritance(): void
public function testSavesIntegerAutoGeneratedValueWithJoinedInheritance(): void
{
$entity = new DDC3634JTIChildEntity();

$this->_em->persist($entity);
$this->_em->flush();

self::assertIsString($entity->id);
self::assertNotNull($entity->id);
}
}

Expand Down