Restore job with --prefer-lowest #10971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
restore-prefer-lowest
branch
5 times, most recently
from
4743f53 to
0e34fcf
Compare
greg0ire
commented
Oct 7, 2023
composer.json
Outdated
| @@ -32,18 +32,18 @@ | |||
| "doctrine/instantiator": "^1.3 || ^2", | |||
| "doctrine/lexer": "^2.1 || ^3", | |||
| "doctrine/persistence": "^3.1.1", | |||
| "psr/cache": "^1 || ^2 || ^3", | |||
| "psr/cache": "^3", | |||
There was a problem hiding this comment.
We require the fluent interface provided by 3.0.0:
orm/lib/Doctrine/ORM/Query.php
Line 276 in 62ed63b
There was a problem hiding this comment.
The fluent interface is part of the standard since v1.
There was a problem hiding this comment.
🤔 I guess the issue must be with a wrong implementation then.
There was a problem hiding this comment.
MockObject_CacheItemInterface_9583ebe3
Ah yes, that makes sense. The mocking framework won't enforce a phpdoc-provided return type.
greg0ire
force-pushed
the
restore-prefer-lowest
branch
from
0e34fcf to
b43759f
Compare
greg0ire
force-pushed
the
restore-prefer-lowest
branch
6 times, most recently
from
aca515e to
eae50e6
Compare
It is useful to catch misconfigured dependency constraints. It was removed in 413c332. This implies configuring mocks so as to support psr/cache 1 psr/cache 1 does not use native return types, and phpdoc is not enough to obtain a mock that has typed methods.
greg0ire
force-pushed
the
restore-prefer-lowest
branch
from
eae50e6 to
2700998
Compare
SenseException
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to catch misconfigured dependency constraints. It was removed in #9069.