Narrow integer to param class constants #10796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You cannot just pass any integer as a type, it has to map to something meaningful. The psalm types introduced here are copied from doctrine/dbal 4, with a small difference: since we are not dealing with actual enums yet, but with class constants, we add ::*, which is compatible with both cases (class or enum).
|
Cannot be done if we still support DBAL 2 🤔 |
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot just pass any integer as a type, it has to map to something meaningful.
The psalm types introduced here are copied from
doctrine/dbal4, with a small difference: since we are not dealing with actual enums yet, but with class constants, we add::*, which is compatible with both cases (class or enum).