Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release 2.15.3 into 2.16.x #10787

Merged
merged 15 commits into from
Jun 22, 2023
Merged

Conversation

wtfzdotnet and others added 15 commits June 6, 2023 18:18
… for orphan removal.

In my case a custom doctrine type of Uuid object is converted to string by simply casting it, resulting in a hex DELETE FROM x WHERE id = ? query,
whilst it should've been converted along the way to it's binary representation. This leads to no deletions being made at all as you would expect making use of doctrine custom type's as an identifier.

This commit fixes usage of ramsey/uuid or symfony/uid as custom id types when making use of orphan removal.
It brings nothing over what PHPUnit now natively does.
Partial objects are deprecated. They were handy to make the generated
SQL more legible, but we should refrain from relying on them.
When collection updates/join table cleanups do not happen through specialized Entity-/CollectionPersister methods but instead as "plain" updates, we may issue a lot more queries than expected.
@greg0ire greg0ire merged commit 6c0a5ec into 2.16.x Jun 22, 2023
@greg0ire greg0ire deleted the 2.15.x-merge-up-into-2.16.x_XV3tWpNu branch June 22, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants