Migrate the rest of the source code to PHP 8 syntax #10509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
php8-migration
branch
from
075b683 to
0a36a39
Compare
derrabus
reviewed
Feb 8, 2023
Comment on lines
48
to
49
| $locator, | ||
| $fileExtension = self::DEFAULT_FILE_EXTENSION, |
| @@ -41,14 +41,14 @@ class XmlDriver extends FileDriver | |||
| { | |||
| public const DEFAULT_FILE_EXTENSION = '.dcm.xml'; | |||
There was a problem hiding this comment.
SimplifiedXmlDriver overrides it.
greg0ire
force-pushed
the
php8-migration
branch
from
0a36a39 to
f5e7ddb
Compare
derrabus
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9772 (yes, finally!)
None of the remaining changes look legit.