Migrate Parser to PHP 8 #10506
Merged
Migrate Parser to PHP 8 #10506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Feb 7, 2023
| */ | ||
| public function SimpleConditionalExpression() | ||
| */ | ||
| public function SimpleConditionalExpression(): AST\ExistsExpression|AST\BetweenExpression|AST\LikeExpression|AST\InListExpression|AST\InSubselectExpression|AST\InstanceOfExpression|AST\CollectionMemberExpression|AST\NullComparisonExpression|AST\EmptyCollectionComparisonExpression|AST\ComparisonExpression |
There was a problem hiding this comment.
Should I simplify this one to AST\Node?
There was a problem hiding this comment.
Depends on how we answer my question regarding final. 🙂
derrabus
requested changes
Feb 7, 2023
lib/Doctrine/ORM/Query/Parser.php
Outdated
| match (true) { | ||
| $AST instanceof AST\UpdateStatement => $treeWalkerChain->walkUpdateStatement($AST), | ||
| $AST instanceof AST\DeleteStatement => $treeWalkerChain->walkDeleteStatement($AST), | ||
| default => $treeWalkerChain->walkSelectStatement($AST), |
There was a problem hiding this comment.
Let's be explicit about the remaining case that we expect here. Static analysis should recognize that the match statement covers all cases without a default and will notify us if that will ever change in the future. 💪🏻
Suggested change
| default => $treeWalkerChain->walkSelectStatement($AST), | |
| $AST instanceof AST\SelectStatement => $treeWalkerChain->walkSelectStatement($AST), |
|
Let's try |
greg0ire
force-pushed
the
php8-migration
branch
from
4dd88d6 to
ce03a61
Compare
derrabus
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, I had to widen the documented type, running the test suite showed me it was wrong.