Psalm 5.5.0 #10445
Merged
Psalm 5.5.0 #10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Jan 23, 2023
| @@ -3,6 +3,8 @@ | |||
| errorLevel="2" | |||
| phpVersion="8.2" | |||
| resolveFromConfigFile="true" | |||
| findUnusedBaselineEntry="true" | |||
There was a problem hiding this comment.
I need to set this flag to avoid a deprecation warning. It defaults to false, but I think enabling it will help us keep the baseline clean. 🤞🏻
There was a problem hiding this comment.
Yeah, we are the ones (well I) asking for that feature so better use it at some point 😛
| @@ -3,6 +3,8 @@ | |||
| errorLevel="2" | |||
| phpVersion="8.2" | |||
| resolveFromConfigFile="true" | |||
| findUnusedBaselineEntry="true" | |||
| findUnusedCode="false" | |||
There was a problem hiding this comment.
Another flag that needs to be set now. Setting it to true causes a lot of new errors, which is why I'd like to do this in a later PR (if we want to do it at all).
greg0ire
approved these changes
Jan 23, 2023
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 26, 2023
* 2.15.x: Deprecate undeclared entity inheritance (doctrine#10431) Psalm 5.5.0 (doctrine#10445)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 26, 2023
* 2.15.x: Deprecate undeclared entity inheritance (doctrine#10431) Psalm 5.5.0 (doctrine#10445)
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jan 26, 2023
* 2.15.x: Deprecate undeclared entity inheritance (doctrine#10431) Psalm 5.5.0 (doctrine#10445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this release, Psalm stops writing
occurrences="X"into the baseline which is why I had to regenerate the whole thing. This is going to be fun when merging up! 🥲