Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write down what "transient" means #10394

Merged
merged 3 commits into from
Jan 14, 2023
Merged

Write down what "transient" means #10394

merged 3 commits into from
Jan 14, 2023

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jan 13, 2023 •
edited
Loading

It feels as if every time I try to debug mapping-related code, I stumble across the term "transient" and have to figure out what it means.

I hope that with this change, Google will bring up a meaningful definition next time.

greg0ire
greg0ire reviewed Jan 13, 2023
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use linebreaks as in the rest of this document

docs/en/reference/architecture.rst Outdated Show resolved Hide resolved
@mpdude
Copy link
Contributor Author

mpdude commented Jan 13, 2023

Fixed

@greg0ire greg0ire merged commit 180afa8 into doctrine:2.14.x Jan 14, 2023
@greg0ire greg0ire added this to the 2.14.1 milestone Jan 14, 2023
@greg0ire
Copy link
Member

Thanks @mpdude !

@mpdude mpdude deleted the what-is-transient branch January 14, 2023 12:22
@github-actions github-actions bot mentioned this pull request Jan 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
2.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mpdude @greg0ire