Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ClassMetadataInfo #10379

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Remove ClassMetadataInfo #10379

merged 1 commit into from
Jan 13, 2023

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jan 7, 2023

Closes #9773

SenseException
SenseException approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH6682Test is using $classMetadataInfo as variable name, but that's just nitpicking.

@greg0ire
Copy link
Member Author

Nice find! I'll address it on the lowest possible branch.

@greg0ire greg0ire merged commit c8b0931 into doctrine:3.0.x Jan 13, 2023
@greg0ire greg0ire deleted the remove-cmi branch January 13, 2023 22:18
@greg0ire greg0ire added this to the 3.0.0 milestone Jan 13, 2023
@greg0ire greg0ire mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @SenseException