Add assertions about non nullability #10302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #10301, I found that the improvements I made resulted in a lot of Psalm errors. A lot of them look like they should also exist with
doctrine/lexer
1, so here is a PR adding assertions, that way it will make it easier to assess the impact of future developments in that area of the code.This also makes me think we might want a better Lexer API with separate methods where we don't expect to obtain
null
. It seems to be the case most of the time.