Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions about non nullability #10302

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Dec 13, 2022

While working on #10301, I found that the improvements I made resulted in a lot of Psalm errors. A lot of them look like they should also exist with doctrine/lexer 1, so here is a PR adding assertions, that way it will make it easier to assess the impact of future developments in that area of the code.

This also makes me think we might want a better Lexer API with separate methods where we don't expect to obtain null. It seems to be the case most of the time.

@greg0ire greg0ire merged commit 13bab31 into doctrine:2.14.x Dec 13, 2022
@greg0ire greg0ire deleted the non-nullability-assertions branch December 13, 2022 22:22
@greg0ire greg0ire added this to the 2.14.0 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants