Make the code easier to statically analyse #10231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Nov 14, 2022
| @@ -1631,7 +1631,7 @@ private function validateAndCompleteTypedFieldMapping(array $mapping): array | |||
| /** | |||
| * Validates & completes the basic mapping information based on typed property. | |||
| * | |||
| * @param mixed[] $mapping The mapping. | |||
| * @param array{type: self::ONE_TO_ONE|self::MANY_TO_ONE|self::ONE_TO_MANY|self::MANY_TO_MANY, fieldName: string, targetEntity?: class-string} $mapping The mapping. | |||
There was a problem hiding this comment.
I couldn't find a way to make this multiline and have phpcs be happy with it… it's probably the pipes.
greg0ire
commented
Nov 14, 2022
| */ | ||
| private function quoteLiteral($literal): string | ||
| { | ||
| if (is_numeric($literal) && ! is_string($literal)) { | ||
| if (is_int($literal) || is_float($literal)) { |
There was a problem hiding this comment.
About this, see vimeo/psalm#8703
SenseException
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on migrating the codebase to PHP 8, I noticed that a rule (
NullToStrictStringFuncCallArgRector) often triggered that consists in adding casts to string, because internal functions have become more strict in PHP 8.1 (they no longer accept anything than a string).I tried finding why those arguments were not considered already strings, and tried to fix some of that with this PR.