Allow "Expr\Func" as condition in join in PHPDoc #10202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use "Expr\Func" as 4th parameter of innerJoin, but according to the PHPDoc it's not allowed:
Solves #8151
Current parameter is https://github.com/doctrine/orm/blob/2.13.x/lib/Doctrine/ORM/QueryBuilder.php#L1025
For example when I use the "in" expression in the join condition:
it generates the query .... WITH u.id IN(1, 2, 3), but currently it's not allowed according to the PHPDoc.